[Intel-gfx] [PATCH] drm/i915/psr: remove unused lines_to_wait vbt info
Souza, Jose
jose.souza at intel.com
Wed Jan 12 12:58:19 UTC 2022
On Wed, 2022-01-12 at 13:27 +0200, Jani Nikula wrote:
> The lines_to_wait info from VBT is never used. Remove.
>
Reviewed-by: José Roberto de Souza <jose.souza at intel.com>
> Cc: José Roberto de Souza <jose.souza at intel.com>
> Cc: Jouni Högander <jouni.hogander at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
> ---
>
> Not exactly a v2, but rather a replacement for [1].
>
> [1] https://patchwork.freedesktop.org/patch/msgid/20220104085421.213793-1-jani.nikula@intel.com
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 20 --------------------
> drivers/gpu/drm/i915/i915_drv.h | 8 --------
> 2 files changed, 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index c7a8d517ce81..262406c00e53 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -905,26 +905,6 @@ parse_psr(struct drm_i915_private *i915, const struct bdb_header *bdb)
> i915->vbt.psr.idle_frames = psr_table->idle_frames < 0 ? 0 :
> psr_table->idle_frames > 15 ? 15 : psr_table->idle_frames;
>
> - switch (psr_table->lines_to_wait) {
> - case 0:
> - i915->vbt.psr.lines_to_wait = PSR_0_LINES_TO_WAIT;
> - break;
> - case 1:
> - i915->vbt.psr.lines_to_wait = PSR_1_LINE_TO_WAIT;
> - break;
> - case 2:
> - i915->vbt.psr.lines_to_wait = PSR_4_LINES_TO_WAIT;
> - break;
> - case 3:
> - i915->vbt.psr.lines_to_wait = PSR_8_LINES_TO_WAIT;
> - break;
> - default:
> - drm_dbg_kms(&i915->drm,
> - "VBT has unknown PSR lines to wait %u\n",
> - psr_table->lines_to_wait);
> - break;
> - }
> -
> /*
> * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
> * Old decimal value is wake up time in multiples of 100 us.
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 6caec2eca8cd..890f1f6fbc49 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -514,13 +514,6 @@ i915_fence_timeout(const struct drm_i915_private *i915)
> /* Amount of PSF GV points, BSpec precisely defines this */
> #define I915_NUM_PSF_GV_POINTS 3
>
> -enum psr_lines_to_wait {
> - PSR_0_LINES_TO_WAIT = 0,
> - PSR_1_LINE_TO_WAIT,
> - PSR_4_LINES_TO_WAIT,
> - PSR_8_LINES_TO_WAIT
> -};
> -
> struct intel_vbt_data {
> /* bdb version */
> u16 version;
> @@ -560,7 +553,6 @@ struct intel_vbt_data {
> bool full_link;
> bool require_aux_wakeup;
> int idle_frames;
> - enum psr_lines_to_wait lines_to_wait;
> int tp1_wakeup_time_us;
> int tp2_tp3_wakeup_time_us;
> int psr2_tp2_tp3_wakeup_time_us;
More information about the Intel-gfx
mailing list