[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support

Patchwork patchwork at emeril.freedesktop.org
Mon Jan 17 19:49:12 UTC 2022


== Series Details ==

Series: Introduce multitile support
URL   : https://patchwork.freedesktop.org/series/98958/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3a9bf34c3413 drm/i915: Prepare for multiple GTs
-:255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#255: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:91:
+#define for_each_gt(gt__, i915__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_MAX_GT; \
+	     (id__)++) \
+		for_each_if(((gt__) = (i915__)->gt[(id__)]))

total: 0 errors, 0 warnings, 1 checks, 436 lines checked
19cc34444270 drm/i915/gt: make a gt sysfs group and move power management files
-:111: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#111: 
new file mode 100644

-:588: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mode' - possible side-effects?
#588: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:293:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:588: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_show' - possible side-effects?
#588: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:293:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:588: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_store' - possible side-effects?
#588: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:293:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:611: CHECK:CAMELCASE: Avoid CamelCase: <RPn_freq_mhz>
#611: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:316:
+static INTEL_GT_RPS_SYSFS_ATTR(RPn_freq_mhz, 0444, rps_rp_mhz_show, NULL);

-:621: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_##s##_RPn_freq_mhz>
#621: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:326:
+		&dev_attr_##s##_RPn_freq_mhz.attr, \

-:640: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19)
#640: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:345:
+	} else if (attr == &dev_attr_gt_RP1_freq_mhz ||
[...]
+		   val = intel_rps_get_rp1_frequency(rps);

-:643: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19)
#643: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:348:
+	} else if (attr == &dev_attr_gt_RPn_freq_mhz ||
[...]
+		   val = intel_rps_get_rpn_frequency(rps);

-:643: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_gt_RPn_freq_mhz>
#643: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:348:
+	} else if (attr == &dev_attr_gt_RPn_freq_mhz ||

-:644: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_rps_RPn_freq_mhz>
#644: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:349:
+		   attr == &dev_attr_rps_RPn_freq_mhz) {

total: 0 errors, 3 warnings, 7 checks, 974 lines checked




More information about the Intel-gfx mailing list