[Intel-gfx] [PATCH 5/5] drm/i915: Move dsc/joiner enable into hsw_crtc_enable()

Ville Syrjälä ville.syrjala at linux.intel.com
Tue Jan 25 05:59:06 UTC 2022


On Tue, Jan 25, 2022 at 07:40:04AM +0200, Jani Nikula wrote:
> On Mon, 24 Jan 2022, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > Lift the dsc/joiner enable up from the wonky places where it
> > currently sits (ddi .pre_enable() or icl_ddi_bigjoiner_pre_enable())
> > into hsw_crtc_enable() where we write the other per-pipe stuff
> > as well. Makes the transcoder vs. pipe split less confusing.
> >
> 
> What about the enable call in DSI?

Hrm. Looks safeish to relocate as well. It will reorder things
vs. the transcoder timings setup, but can't really think why
that should matter

I'm actually thinking of reordering these a bit for DP/DHMI 
as well. Would let us move the whole hsw_configure_cpu_transcoder()
call into the ddi .pre_enable(). Though MST may get in the way of
that plan :/

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list