[Intel-gfx] [PATCH] drm/i915: Fix header test for !CONFIG_X86

Lucas De Marchi lucas.demarchi at intel.com
Tue Jan 25 20:55:13 UTC 2022


On Tue, Jan 25, 2022 at 10:31:42AM -0800, Lucas De Marchi wrote:
>Architectures other than x86 have a stub implementation calling
>pr_err() and WARN_ON_ONCE(). The appropriate headers need to be
>included, otherwise the header-test target will fail with:
>
>  HDRTEST drivers/gpu/drm/i915/i915_mm.h
>In file included from <command-line>:
>./drivers/gpu/drm/i915/i915_mm.h: In function ‘remap_io_mapping’:
>./drivers/gpu/drm/i915/i915_mm.h:25:2: error: implicit declaration of function ‘pr_err’ [-Werror=implicit-function-declaration]
>   25 |  pr_err("Architecture has no %s() and shouldn't be calling this function\n", __func__);
>      |  ^~~~~~

actually the pr_err() may be excessive spam to the log. Maybe just
remove it together with the ones from drm_cache.c

Lucas De Marchi


More information about the Intel-gfx mailing list