[Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message

[Lucas De Marchi]

On Wed, Jan 26, 2022 at 08:24:54PM +0200, Jani Nikula wrote:
>On Tue, 25 Jan 2022, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
>> Only x86 and in some cases PPC have support added in drm_cache.c for the
>> clflush class of functions. However warning once is sufficient to taint
>> the log instead of spamming it with "Architecture has no drm_cache.c
>> support" every few millisecond.
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Cc: Maxime Ripard <mripard at kernel.org>
>> Cc: Thomas Zimmermann <tzimmermann at suse.de>
>> Cc: David Airlie <airlied at linux.ie>
>> Cc: Daniel Vetter <daniel at ffwll.ch>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> ---
>>  drivers/gpu/drm/drm_cache.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
>> index f19d9acbe959..2d5a4c463a4f 100644
>> --- a/drivers/gpu/drm/drm_cache.c
>> +++ b/drivers/gpu/drm/drm_cache.c
>> @@ -112,7 +112,6 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
>>  		kunmap_atomic(page_virtual);
>>  	}
>>  #else
>> -	pr_err("Architecture has no drm_cache.c support\n");
>>  	WARN_ON_ONCE(1);
>
>An alternative would be to replace the two lines with:
>
>	WARN_ONCE(1, "Architecture has no drm_cache.c support\n");
>
>But I'm not insisting.

I actually like that suggestion. I will change that in the next version.

Thanks
Lucas De Marchi