[Intel-gfx] [PATCH v2 2/6] drm/i915/perf: Express OA register ranges with i915_range

Lucas De Marchi lucas.demarchi at intel.com
Wed Jan 26 22:19:43 UTC 2022


On Mon, Jan 24, 2022 at 06:08:22PM -0800, Matt Roper wrote:
>Let's use 'struct i915_range' to express sets of b-counter and mux
>registers in the perf code.  This makes the code more similar to how we
>handle things like multicast register ranges, forcewake tables, shadow
>tables, etc. and also lets us avoid needing symbolic register name
>definitions for the various range end points.  With this change, many of
>the OA register definitions are no longer used in the code, so we can
>drop their #define's for simplicity.
>
>v2:  Drop 'inline' from reg_in_range_table().  (Jani)
>
>Cc: Jani Nikula <jani.nikula at intel.com>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
>Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


I didn't come up with an idea to review the table ranges, but agree with
the change:

Acked-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


More information about the Intel-gfx mailing list