[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: support v69 in parallel to v70

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 18 23:40:17 UTC 2022


== Series Details ==

Series: drm/i915/guc: support v69 in parallel to v70
URL   : https://patchwork.freedesktop.org/series/106457/
State : warning

== Summary ==

Error: dim checkpatch failed
5b8282554b81 drm/i915/guc: support v69 in parallel to v70
-:742: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#742: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:73:
+#define INTEL_GUC_FIRMWARE_DEFS_FALLBACK(fw_def, guc_def) \
+	fw_def(ALDERLAKE_P,  0, guc_def(adlp, 69, 0, 3)) \
+	fw_def(ALDERLAKE_S,  0, guc_def(tgl,  69, 0, 3))

-:742: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fw_def' - possible side-effects?
#742: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:73:
+#define INTEL_GUC_FIRMWARE_DEFS_FALLBACK(fw_def, guc_def) \
+	fw_def(ALDERLAKE_P,  0, guc_def(adlp, 69, 0, 3)) \
+	fw_def(ALDERLAKE_S,  0, guc_def(tgl,  69, 0, 3))

-:742: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'guc_def' - possible side-effects?
#742: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:73:
+#define INTEL_GUC_FIRMWARE_DEFS_FALLBACK(fw_def, guc_def) \
+	fw_def(ALDERLAKE_P,  0, guc_def(adlp, 69, 0, 3)) \
+	fw_def(ALDERLAKE_S,  0, guc_def(tgl,  69, 0, 3))

total: 1 errors, 0 warnings, 2 checks, 771 lines checked




More information about the Intel-gfx mailing list