[Intel-gfx] [RFC PATCH 0/2] i915 writeback enablement

Kandpal, Suraj suraj.kandpal at intel.com
Mon Jun 13 05:15:51 UTC 2022


> With this we try to enable writeback feature keeping with the drm_core
> drm_writeback framework but to do this we have to create a drm_encoder
> and drm_connector which is not present in intel_connector and
> intel_encoder which causes all our iterators to bug out as they assume any
> drm_encoder and drm_connector will naturally be embedded in the intel_
> counterpart structures but this cannot be acheived from
> drm_writeback_connector as the drm_encoder and drm_connector fields in
> the structure are pointers which does not allow us to embed them in our
> intel_ structures.I have tried to change some iterators and show what further
> changes may look like but this will happen any and every place
> for_each_intel_encoder or for_each_intel_connector_ is going to be used.I
> would like suggestions on if moving forward with this approach would be
> useful or if the private i915 framework mentioned below sounds more
> practical.
> We previously tried to change the drm_connector and drm_encoder fields
> into pointer in the drm_writeback_connector structure but faced a huge
> backlash from community.
> Other than this approach we have another solution which won't be as much
> of a work and will require minimal changes is where we take the whole
> drm_writeback framework that is being used pull it into i915 making it
> private and change the encoder and connector fields to pointers. The
> approach has been floated in below series [1]
> https://patchwork.freedesktop.org/series/103417/


Hi Daniel,
Any suggestions how we can proceed with this.

BR,
Suraj Kandpal


More information about the Intel-gfx mailing list