[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for remove shmem backend and region and unify them with TTM

Patchwork patchwork at emeril.freedesktop.org
Tue Jun 14 02:53:22 UTC 2022


== Series Details ==

Series: remove shmem backend and region and unify them with TTM
URL   : https://patchwork.freedesktop.org/series/105087/
State : warning

== Summary ==

Error: dim checkpatch failed
aec7d1e6a46b drm/i915/ttm: dont trample cache_level overrides during ttm move
-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8: 
Before ttm, these overrides were permanent until explicitly changed again or

-:76: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Adrian Larumbe <adrian.larumbe at collabora.com>'

total: 1 errors, 1 warnings, 0 checks, 36 lines checked
99b6a599e0a2 drm/i915/ttm: don't overwrite cache_dirty after setting coherency
-:14: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '2f0ec95ed20c', maybe rebased or not pulled?
#14: 
placement of the framebuffer. However, commit 2f0ec95ed20c ("drm/i915/ttm:

total: 0 errors, 1 warnings, 0 checks, 11 lines checked
5470a2530054 drm/i915/ttm: remove shmem memory region and gem object backend
-:91: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj->base.filp"
#91: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:91:
+		GEM_WARN_ON(obj->base.filp != NULL);

-:693: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#693: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:189:
+ttm_create_shmem_file(struct drm_i915_private *dev_priv,
+		       const size_t size)

-:834: CHECK:BRACES: braces {} should be used on all arms of this statement
#834: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:945:
+	if (likely(i915_gem_object_has_struct_page(obj) || IS_DGFX(i915))) {
[...]
+	} else
[...]

-:857: CHECK:BRACES: Unbalanced braces around else statement
#857: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:968:
+	} else

total: 0 errors, 0 warnings, 4 checks, 1108 lines checked




More information about the Intel-gfx mailing list