[Intel-gfx] [PATCH v2 0/2] i915: Extract, polish, and document multicast handling
Matt Roper
matthew.d.roper at intel.com
Wed Jun 15 00:10:17 UTC 2022
Multicast/replicated (MCR) registers on Intel hardware are a purely
GT-specific concept. Rather than leaving MCR register handling spread
across several places throughout the driver (intel_uncore.c, intel_gt.c,
etc.) with confusing combinations of handler functions living in
different namespaces, let's consolidate it all into a single place
(intel_gt_mcr.c) and provide a more consistent and clearly-documented
interface for the rest of the driver to access such registers:
* intel_gt_mcr_read -- unicast read from specific instance
* intel_gt_mcr_read_any[_fw] -- unicast read from any non-terminated
instance
* intel_gt_mcr_unicast_write -- unicast write to specific instance
* intel_gt_mcr_multicast_write[_fw] -- multicast write to all instances
v2:
- Reference the new kerneldoc from i915.rst. (Jani)
- Tweak the wording of the documentation for a couple functions to
clarify the difference between "_fw" and non-"_fw" forms.
Matt Roper (2):
drm/i915/gt: Move multicast register handling to a dedicated file
drm/i915/gt: Cleanup interface for MCR operations
Documentation/gpu/i915.rst | 12 +
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 3 +-
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 36 +-
drivers/gpu/drm/i915/gt/intel_gt.c | 297 +-----------
drivers/gpu/drm/i915/gt/intel_gt.h | 15 -
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 3 +-
drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 497 ++++++++++++++++++++
drivers/gpu/drm/i915/gt/intel_gt_mcr.h | 34 ++
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 5 +-
drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 +-
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 3 +-
drivers/gpu/drm/i915/i915_drv.h | 2 -
drivers/gpu/drm/i915/intel_uncore.c | 112 -----
drivers/gpu/drm/i915/intel_uncore.h | 8 -
15 files changed, 577 insertions(+), 460 deletions(-)
create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_mcr.c
create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_mcr.h
--
2.35.3
More information about the Intel-gfx
mailing list