[Intel-gfx] [PATCH 4/4] drm/i915/hwmon: Add HWMON energy support

[Dixit, Ashutosh]

On Mon, 20 Jun 2022 14:04:53 -0700, Guenter Roeck wrote:
>
> > @@ -141,9 +282,12 @@ i915_power1_max_default_show(struct device *dev, struct device_attribute *attr,
> >     static SENSOR_DEVICE_ATTR(power1_max_default, 0444,
> >			  i915_power1_max_default_show, NULL, 0);
> > +static SENSOR_DEVICE_ATTR(energy1_input, 0444,
> > +			  i915_energy1_input_show, NULL, 0);
> >     static struct attribute *hwmon_attributes[] = {
> >	&sensor_dev_attr_power1_max_default.dev_attr.attr,
> > +	&sensor_dev_attr_energy1_input.dev_attr.attr,
>
> Why not use HWMON_E_INPUT ?

Agreed, we will investigate switching to this. I also had a similar comment
about this here:

https://patchwork.freedesktop.org/patch/487020/?series=104278&rev=1

Thanks.
--
Ashutosh