[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] iosys-map: Add per-word read
Patchwork
patchwork at emeril.freedesktop.org
Tue Jun 28 22:28:09 UTC 2022
== Series Details ==
Series: series starting with [CI,1/2] iosys-map: Add per-word read
URL : https://patchwork.freedesktop.org/series/105746/
State : warning
== Summary ==
Error: dim checkpatch failed
52de7a46693f iosys-map: Add per-word read
-:93: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#93: FILE: include/linux/iosys-map.h:339:
+ u64: val_ = readq(vaddr_iomem_)
^
-:93: WARNING:INDENTED_LABEL: labels should not be indented
#93: FILE: include/linux/iosys-map.h:339:
+ u64: val_ = readq(vaddr_iomem_)
-:96: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#96: FILE: include/linux/iosys-map.h:342:
+ u64: memcpy_fromio(&(val_), vaddr_iomem_, sizeof(u64))
^
-:96: WARNING:INDENTED_LABEL: labels should not be indented
#96: FILE: include/linux/iosys-map.h:342:
+ u64: memcpy_fromio(&(val_), vaddr_iomem_, sizeof(u64))
-:99: CHECK:CAMELCASE: Avoid CamelCase: <_Generic>
#99: FILE: include/linux/iosys-map.h:345:
+#define __iosys_map_rd_io(val__, vaddr_iomem__, type__) _Generic(val__, \
-:99: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val__' - possible side-effects?
#99: FILE: include/linux/iosys-map.h:345:
+#define __iosys_map_rd_io(val__, vaddr_iomem__, type__) _Generic(val__, \
+ u8: val__ = readb(vaddr_iomem__), \
+ u16: val__ = readw(vaddr_iomem__), \
+ u32: val__ = readl(vaddr_iomem__), \
+ __iosys_map_rd_io_u64_case(val__, vaddr_iomem__))
-:99: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vaddr_iomem__' - possible side-effects?
#99: FILE: include/linux/iosys-map.h:345:
+#define __iosys_map_rd_io(val__, vaddr_iomem__, type__) _Generic(val__, \
+ u8: val__ = readb(vaddr_iomem__), \
+ u16: val__ = readw(vaddr_iomem__), \
+ u32: val__ = readl(vaddr_iomem__), \
+ __iosys_map_rd_io_u64_case(val__, vaddr_iomem__))
-:100: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#100: FILE: include/linux/iosys-map.h:346:
+ u8: val__ = readb(vaddr_iomem__), \
^
-:100: WARNING:INDENTED_LABEL: labels should not be indented
#100: FILE: include/linux/iosys-map.h:346:
+ u8: val__ = readb(vaddr_iomem__), \
-:101: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#101: FILE: include/linux/iosys-map.h:347:
+ u16: val__ = readw(vaddr_iomem__), \
^
-:101: WARNING:INDENTED_LABEL: labels should not be indented
#101: FILE: include/linux/iosys-map.h:347:
+ u16: val__ = readw(vaddr_iomem__), \
-:102: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#102: FILE: include/linux/iosys-map.h:348:
+ u32: val__ = readl(vaddr_iomem__), \
^
-:102: WARNING:INDENTED_LABEL: labels should not be indented
#102: FILE: include/linux/iosys-map.h:348:
+ u32: val__ = readl(vaddr_iomem__), \
-:105: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#105: FILE: include/linux/iosys-map.h:351:
+#define __iosys_map_rd_sys(val__, vaddr__, type__) \
+ val__ = READ_ONCE(*(type__ *)(vaddr__));
-:105: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'type__' may be better as '(type__)' to avoid precedence issues
#105: FILE: include/linux/iosys-map.h:351:
+#define __iosys_map_rd_sys(val__, vaddr__, type__) \
+ val__ = READ_ONCE(*(type__ *)(vaddr__));
-:105: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#105: FILE: include/linux/iosys-map.h:351:
+#define __iosys_map_rd_sys(val__, vaddr__, type__) \
+ val__ = READ_ONCE(*(type__ *)(vaddr__));
-:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'map__' - possible side-effects?
#128: FILE: include/linux/iosys-map.h:368:
+#define iosys_map_rd(map__, offset__, type__) ({ \
+ type__ val; \
+ if ((map__)->is_iomem) { \
+ __iosys_map_rd_io(val, (map__)->vaddr_iomem + (offset__), type__);\
+ } else { \
+ __iosys_map_rd_sys(val, (map__)->vaddr + (offset__), type__); \
+ } \
+ val; \
})
-:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset__' - possible side-effects?
#128: FILE: include/linux/iosys-map.h:368:
+#define iosys_map_rd(map__, offset__, type__) ({ \
+ type__ val; \
+ if ((map__)->is_iomem) { \
+ __iosys_map_rd_io(val, (map__)->vaddr_iomem + (offset__), type__);\
+ } else { \
+ __iosys_map_rd_sys(val, (map__)->vaddr + (offset__), type__); \
+ } \
+ val; \
})
-:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'type__' - possible side-effects?
#128: FILE: include/linux/iosys-map.h:368:
+#define iosys_map_rd(map__, offset__, type__) ({ \
+ type__ val; \
+ if ((map__)->is_iomem) { \
+ __iosys_map_rd_io(val, (map__)->vaddr_iomem + (offset__), type__);\
+ } else { \
+ __iosys_map_rd_sys(val, (map__)->vaddr + (offset__), type__); \
+ } \
+ val; \
})
total: 6 errors, 6 warnings, 7 checks, 70 lines checked
0a1be70e6733 iosys-map: Add per-word write
-:36: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#36: FILE: include/linux/iosys-map.h:341:
+ u64: writeq(val_, vaddr_iomem_)
^
-:36: WARNING:INDENTED_LABEL: labels should not be indented
#36: FILE: include/linux/iosys-map.h:341:
+ u64: writeq(val_, vaddr_iomem_)
-:41: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#41: FILE: include/linux/iosys-map.h:346:
+ u64: memcpy_toio(vaddr_iomem_, &(val_), sizeof(u64))
^
-:41: WARNING:INDENTED_LABEL: labels should not be indented
#41: FILE: include/linux/iosys-map.h:346:
+ u64: memcpy_toio(vaddr_iomem_, &(val_), sizeof(u64))
-:49: CHECK:CAMELCASE: Avoid CamelCase: <_Generic>
#49: FILE: include/linux/iosys-map.h:358:
+#define __iosys_map_wr_io(val__, vaddr_iomem__, type__) _Generic(val__, \
-:49: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val__' - possible side-effects?
#49: FILE: include/linux/iosys-map.h:358:
+#define __iosys_map_wr_io(val__, vaddr_iomem__, type__) _Generic(val__, \
+ u8: writeb(val__, vaddr_iomem__), \
+ u16: writew(val__, vaddr_iomem__), \
+ u32: writel(val__, vaddr_iomem__), \
+ __iosys_map_wr_io_u64_case(val__, vaddr_iomem__))
-:49: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vaddr_iomem__' - possible side-effects?
#49: FILE: include/linux/iosys-map.h:358:
+#define __iosys_map_wr_io(val__, vaddr_iomem__, type__) _Generic(val__, \
+ u8: writeb(val__, vaddr_iomem__), \
+ u16: writew(val__, vaddr_iomem__), \
+ u32: writel(val__, vaddr_iomem__), \
+ __iosys_map_wr_io_u64_case(val__, vaddr_iomem__))
-:50: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#50: FILE: include/linux/iosys-map.h:359:
+ u8: writeb(val__, vaddr_iomem__), \
^
-:50: WARNING:INDENTED_LABEL: labels should not be indented
#50: FILE: include/linux/iosys-map.h:359:
+ u8: writeb(val__, vaddr_iomem__), \
-:51: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#51: FILE: include/linux/iosys-map.h:360:
+ u16: writew(val__, vaddr_iomem__), \
^
-:51: WARNING:INDENTED_LABEL: labels should not be indented
#51: FILE: include/linux/iosys-map.h:360:
+ u16: writew(val__, vaddr_iomem__), \
-:52: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#52: FILE: include/linux/iosys-map.h:361:
+ u32: writel(val__, vaddr_iomem__), \
^
-:52: WARNING:INDENTED_LABEL: labels should not be indented
#52: FILE: include/linux/iosys-map.h:361:
+ u32: writel(val__, vaddr_iomem__), \
-:55: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'type__' may be better as '(type__)' to avoid precedence issues
#55: FILE: include/linux/iosys-map.h:364:
+#define __iosys_map_wr_sys(val__, vaddr__, type__) \
+ WRITE_ONCE(*(type__ *)(vaddr__), val__);
-:55: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#55: FILE: include/linux/iosys-map.h:364:
+#define __iosys_map_wr_sys(val__, vaddr__, type__) \
+ WRITE_ONCE(*(type__ *)(vaddr__), val__);
-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'map__' - possible side-effects?
#74: FILE: include/linux/iosys-map.h:403:
+#define iosys_map_wr(map__, offset__, type__, val__) ({ \
+ type__ val = (val__); \
+ if ((map__)->is_iomem) { \
+ __iosys_map_wr_io(val, (map__)->vaddr_iomem + (offset__), type__);\
+ } else { \
+ __iosys_map_wr_sys(val, (map__)->vaddr + (offset__), type__); \
+ } \
})
-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset__' - possible side-effects?
#74: FILE: include/linux/iosys-map.h:403:
+#define iosys_map_wr(map__, offset__, type__, val__) ({ \
+ type__ val = (val__); \
+ if ((map__)->is_iomem) { \
+ __iosys_map_wr_io(val, (map__)->vaddr_iomem + (offset__), type__);\
+ } else { \
+ __iosys_map_wr_sys(val, (map__)->vaddr + (offset__), type__); \
+ } \
})
-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'type__' - possible side-effects?
#74: FILE: include/linux/iosys-map.h:403:
+#define iosys_map_wr(map__, offset__, type__, val__) ({ \
+ type__ val = (val__); \
+ if ((map__)->is_iomem) { \
+ __iosys_map_wr_io(val, (map__)->vaddr_iomem + (offset__), type__);\
+ } else { \
+ __iosys_map_wr_sys(val, (map__)->vaddr + (offset__), type__); \
+ } \
})
total: 5 errors, 6 warnings, 7 checks, 66 lines checked
More information about the Intel-gfx
mailing list