[Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

Murthy, Arun R arun.r.murthy at intel.com
Wed Jun 29 04:16:39 UTC 2022



> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of
> Andrzej Hajda
> Sent: Thursday, June 23, 2022 10:08 PM
> To: Jani Nikula <jani.nikula at linux.intel.com>; Ville Syrjälä
> <ville.syrjala at linux.intel.com>
> Cc: Hajda, Andrzej <andrzej.hajda at intel.com>; intel-
> gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; Vivi, Rodrigo
> <rodrigo.vivi at intel.com>
> Subject: [Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work
> after last user suspension
>
> i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler
> called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst.
> To avoid re-queuing lets cancel HPD work after intel_dp_mst_suspend.
>
It is not re-queuing!
I Would rather put it as, a cleaner approach is to flush the hpd work on
suspend.

With the above said changes included, you can have
Reviewed-by: Arun R Murthy <arun.r.murthy at intel.com>

Thanks and Regards,
Arun R Murthy
--------------------


More information about the Intel-gfx mailing list