[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: Rework BDB block handling (rev3)

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 17 22:16:44 UTC 2022


== Series Details ==

Series: drm/i915/bios: Rework BDB block handling (rev3)
URL   : https://patchwork.freedesktop.org/series/101496/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f78f0208e580 drm/i915/bios: Extract struct lvds_lfp_data_ptr_table
b9aaa74b14b4 drm/i915/bios: Make copies of VBT data blocks
2b5fbda9a559 drm/i915/bios: Use the copy of the LFP data table always
4d30945afa1f drm/i915/bios: Validate LFP data table pointers
-:86: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#86: FILE: drivers/gpu/drm/i915/display/intel_bios.c:219:
+		if (ptrs->ptr[i].fp_timing.offset - ptrs->ptr[i-1].fp_timing.offset != lfp_data_size ||

-:86: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#86: FILE: drivers/gpu/drm/i915/display/intel_bios.c:219:
+		if (ptrs->ptr[i].fp_timing.offset - ptrs->ptr[i-1].fp_timing.offset != lfp_data_size ||
 		                                               ^

-:87: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#87: FILE: drivers/gpu/drm/i915/display/intel_bios.c:220:
+		    ptrs->ptr[i].dvo_timing.offset - ptrs->ptr[i-1].dvo_timing.offset != lfp_data_size ||

-:87: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#87: FILE: drivers/gpu/drm/i915/display/intel_bios.c:220:
+		    ptrs->ptr[i].dvo_timing.offset - ptrs->ptr[i-1].dvo_timing.offset != lfp_data_size ||
 		                                                ^

-:88: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#88: FILE: drivers/gpu/drm/i915/display/intel_bios.c:221:
+		    ptrs->ptr[i].panel_pnp_id.offset - ptrs->ptr[i-1].panel_pnp_id.offset != lfp_data_size)

-:88: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#88: FILE: drivers/gpu/drm/i915/display/intel_bios.c:221:
+		    ptrs->ptr[i].panel_pnp_id.offset - ptrs->ptr[i-1].panel_pnp_id.offset != lfp_data_size)
 		                                                  ^

total: 0 errors, 3 warnings, 3 checks, 94 lines checked
3163d2ce4d8e drm/i915/bios: Trust the LFP data pointers
b88f44efc47e drm/i915/bios: Validate the panel_name table
79016ff6119f drm/i915/bios: Reorder panel DTD parsing
954a9b37adaa drm/i915/bios: Generate LFP data table pointers if the VBT lacks them
-:39: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#39: FILE: drivers/gpu/drm/i915/display/intel_bios.c:283:
+		if (data[i] == 0xff && data[i+1] == 0xff)
 		                             ^

-:123: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#123: FILE: drivers/gpu/drm/i915/display/intel_bios.c:367:
+		next_lfp_data_ptr(&ptrs->ptr[i].fp_timing, &ptrs->ptr[i-1].fp_timing, size);
 		                                                       ^

-:124: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#124: FILE: drivers/gpu/drm/i915/display/intel_bios.c:368:
+		next_lfp_data_ptr(&ptrs->ptr[i].dvo_timing, &ptrs->ptr[i-1].dvo_timing, size);
 		                                                        ^

-:125: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#125: FILE: drivers/gpu/drm/i915/display/intel_bios.c:369:
+		next_lfp_data_ptr(&ptrs->ptr[i].panel_pnp_id, &ptrs->ptr[i-1].panel_pnp_id, size);
 		                                                          ^

total: 0 errors, 0 warnings, 4 checks, 163 lines checked
008090abbd52 drm/i915/bios: Get access to the tail end of the LFP data block
c04a3e89df19 drm/i915/bios: Parse the seamless DRRS min refresh rate
028a04f58900 drm/i915: Respect VBT seamless DRRS min refresh rate




More information about the Intel-gfx mailing list