[Intel-gfx] [PATCH v2 11/11] drm/i915: Allow static DRRS on LVDS

[Jani Nikula]

On Thu, 31 Mar 2022, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Nothing special about static DRRS on LVDS, it's just your
> bog standard modeset. Let's allow it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_lvds.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
> index 73129d21f5e5..e8478161f8b9 100644
> --- a/drivers/gpu/drm/i915/display/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/display/intel_lvds.c
> @@ -968,7 +968,8 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
>  	intel_connector->edid = edid;
>  
>  	/* Try EDID first */
> -	intel_panel_add_edid_fixed_modes(intel_connector, false);
> +	intel_panel_add_edid_fixed_modes(intel_connector,
> +					 dev_priv->vbt.drrs_type != DRRS_TYPE_NONE);

I guess the final question on this, and the previous patch for that
matter, is why would the VBT block your regular modeset between two
different refresh rates?

It does sound like the VBT setting is more about OEM decided policy than
anything else.

Anyway,

Reviewed-by: Jani Nikula <jani.nikula at intel.com>

>  
>  	/* Failed to get EDID, what about VBT? */
>  	if (!intel_panel_preferred_fixed_mode(intel_connector))

-- 
Jani Nikula, Intel Open Source Graphics Center