[Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

Harry Wentland harry.wentland at amd.com
Mon May 2 13:38:49 UTC 2022



On 2022-05-02 09:28, Modem, Bhanuprakash wrote:
> On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote:
>>
>>
>>> -----Original Message-----
>>> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of
>>> Bhanuprakash Modem
>>> Sent: Monday, April 11, 2022 3:21 PM
>>> To: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org;
>>> amd-
>>> gfx at lists.freedesktop.org; jani.nikula at linux.intel.com;
>>> ville.syrjala at linux.intel.com; harry.wentland at amd.com; Sharma, Swati2
>>> <swati2.sharma at intel.com>
>>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
>>> Subject: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to
>>> drm
>>>
>>> As drm_connector already have the display_info, instead of creating
>>> "output_bpc" debugfs in vendor specific driver, move the logic to the
>>> drm
>>> layer.
>>>
>>> This patch will also move "Current" bpc to the crtc debugfs from
>>> connector
>>> debugfs, since we are getting this info from crtc_state.
>>>
>>> Cc: Harry Wentland <harry.wentland at amd.com>
>>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
>>> Reported-by: kernel test robot <lkp at intel.com>
>>> ---
>> Reviewed-by: Arun R Murthy <arun.r.murthy at intel.com>
> 
> Thanks Arun,
> 
> @Harry/@Rodrigo, If this change sounds good to you, can you please help
> to push it?
> 

This changes the output_bpc debugfs behavior on amdgpu and breaks
the amd_max_bpc IGT test. I don't think we should merge this as-is.

This patch also seems dependent on patch 1 of the series. Shouldn't
they be merged together (please don't merge them as-is, though)?

Harry

> - Bhanu
> 
>>
>> Thanks and Regards,
>> Arun R Murthy
>> --------------------
> 


More information about the Intel-gfx mailing list