[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Replace shmem memory region and object backend
Patchwork
patchwork at emeril.freedesktop.org
Tue May 17 21:51:20 UTC 2022
== Series Details ==
Series: Replace shmem memory region and object backend
URL : https://patchwork.freedesktop.org/series/104105/
State : warning
== Summary ==
Error: dim checkpatch failed
a310d6e73af3 drm/i915: Replace shmem memory region and object backend with TTM
-:41: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj->base.import_attach"
#41: FILE: drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:101:
+ GEM_BUG_ON(obj->base.import_attach != NULL);
-:67: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj->base.import_attach"
#67: FILE: drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:231:
+ GEM_BUG_ON(obj->base.import_attach != NULL);
-:98: CHECK:BRACES: Unbalanced braces around else statement
#98: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:90:
+ else {
-:201: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj->base.import_attach"
#201: FILE: drivers/gpu/drm/i915/gem/i915_gem_phys.c:33:
+ GEM_BUG_ON(obj->base.import_attach != NULL);
-:217: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!filp"
#217: FILE: drivers/gpu/drm/i915/gem/i915_gem_phys.c:115:
+ if (GEM_WARN_ON(filp == NULL))
-:650: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!file"
#650: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:316:
+ GEM_WARN_ON(file == NULL);
-:781: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'caching != ttm_write_combined'
#781: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:333:
+ if (i915_gem_object_is_shrinkable(obj) && (caching != ttm_write_combined)) {
-:832: CHECK:BRACES: braces {} should be used on all arms of this statement
#832: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:912:
+ if (likely(i915_gem_object_has_struct_page(obj))) {
[...]
+ } else
[...]
-:842: CHECK:BRACES: Unbalanced braces around else statement
#842: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:922:
+ } else
total: 0 errors, 0 warnings, 9 checks, 1116 lines checked
More information about the Intel-gfx
mailing list