[Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Add HWMON current voltage support

[Dixit, Ashutosh]

On Mon, 23 May 2022 04:08:41 -0700, Badal Nilawar wrote:
>
> +static umode_t
> +i915_in_is_visible(const struct i915_hwmon_drvdata *ddat, u32 attr)
> +{
> +	struct drm_i915_private *i915 = ddat->dd_uncore->i915;
> +
> +	switch (attr) {
> +	case hwmon_in_input:
> +		return (IS_DG1(i915) || IS_DG2(i915)) ? 0444 : 0;

Nit but maybe we should change this to:

		return i915_mmio_reg_valid() ? 0444 : 0;

So that the platform checks are in one place in
i915_hwmon_get_preregistration_info()?