[Intel-gfx] [PATCH 12/15] drm/i915/bios: Split VBT data into per-panel vs. global parts

[Ville Syrjälä]

On Wed, May 25, 2022 at 11:44:05AM +0300, Jani Nikula wrote:
> On Tue, 10 May 2022, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > Move the panel specific VBT parsing to happen during the
> > output probing stage. Needs to be done because the VBT
> > parsing will need to look at the EDID to determine
> > the correct panel_type on some machines.
> >
> > We split the parsed VBT data (i915->vbt) along the same
> > boundary. For the moment we just hoist all the panel
> > specific stuff into connector->panel.vbt since that seems
> > like the most convenient place for eg. the backlight code.
> 
> For a lot of stuff I was thinking we'd hang this stuff off of the
> encoder, but I guess for panel stuff this makes sense. Child device
> stuff in the encoder then.

Yeah, not really sure where to stuff it all. Also a bunch of it might
just be able to be disappeared eventually. Just took the easiest
approach here for the moment.

> 
> >  drivers/gpu/drm/i915/i915_drv.h               |  63 ---
> 
> Gotta love this.
> 
> > diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c
> > index 166caf293f7b..7da4a9cbe4ba 100644
> > --- a/drivers/gpu/drm/i915/display/intel_drrs.c
> > +++ b/drivers/gpu/drm/i915/display/intel_drrs.c
> > @@ -217,9 +217,6 @@ static void intel_drrs_frontbuffer_update(struct drm_i915_private *dev_priv,
> >  {
> >  	struct intel_crtc *crtc;
> >  
> > -	if (dev_priv->vbt.drrs_type != DRRS_TYPE_SEAMLESS)
> > -		return;
> 
> I think this was the only unexplained thing in the entire monster patch
> that I could spot. With that explained, even just in reply,

This gets called for the whole device, so we don't know which
panel we're dealing with here. It was just a micro optimization
to avoid having to look through the crtcs to figure out which ones
are affected, so dropping it won't cause any functional changes.

> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>

Thanks.

> 
> > -
> >  	for_each_intel_crtc(&dev_priv->drm, crtc) {
> >  		unsigned int frontbuffer_bits;
> >  
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center

-- 
Ville Syrjälä
Intel