[Intel-gfx] [PATCH] drm/i915/guc: make default_lists const data

Lucas De Marchi lucas.demarchi at intel.com
Tue Nov 22 17:38:20 UTC 2022


On Tue, Nov 22, 2022 at 04:16:16PM +0200, Jani Nikula wrote:
>The default_lists array should be in rodata.
>
>Fixes: dce2bd542337 ("drm/i915/guc: Add Gen9 registers for GuC error state capture.")
>Cc: Alan Previn <alan.previn.teres.alexis at intel.com>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Signed-off-by: Jani Nikula <jani.nikula at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>---
> drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
>index 1d49a7ec0bd8..1c1b85073b4b 100644
>--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
>+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
>@@ -170,7 +170,7 @@ static const struct __guc_mmio_reg_descr empty_regs_list[] = {
> 	}
>
> /* List of lists */
>-static struct __guc_mmio_reg_descr_group default_lists[] = {
>+static const struct __guc_mmio_reg_descr_group default_lists[] = {
> 	MAKE_REGLIST(default_global_regs, PF, GLOBAL, 0),
> 	MAKE_REGLIST(default_rc_class_regs, PF, ENGINE_CLASS, GUC_RENDER_CLASS),
> 	MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_RENDER_CLASS),
>-- 
>2.34.1
>


More information about the Intel-gfx mailing list