[Intel-gfx] [PATCH 1/2] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

[Teres Alexis, Alan Previn]

On Mon, 2022-11-21 at 16:14 -0800, Juston Li wrote:
> On Thu, 2022-11-17 at 16:36 -0800, Alan Previn wrote:
> > 
Alan: [snip]
> > +void intel_pxp_tee_end_all_fw_sessions(struct intel_pxp *pxp, u32
> > sessions_mask)
> > +{
> > +       int n;
> > +
> > +       for (n = 0; n < INTEL_PXP_MAX_HWDRM_SESSIONS; ++n) {
> > +               intel_pxp_tee_end_one_fw_session(pxp, n,
> > (sessions_mask & 0x1) ? true : false);
> 
> What's the reason for the is_alive bool here? Instead of only sending
> the invalidate cmd for the alive sessions?
> 
> Although... for upstream we really only need to invalidate the ARB
> session right?
> 
> Juston
> 

Yes - will fix that - only the downstream code would need that behavior.

> > +               sessions_mask = (sessions_mask >> 1);
> > +       }
> > +}