[Intel-gfx] [PATCH 1/6] drm/i915/uc: Introduce GSC FW

[Teres Alexis, Alan Previn]

Besides the nit below, just would like to echo the same thing Nikula said about not including the type definition in the
main uc header (which i know can be a bit more work especially if we go with allocation of the structure at init time
and using a ptr in the uc structure). 

That said,
Reviewed-by: Alan Previn <alan.previn.teres.alexis at intel.com>

On Mon, 2022-11-21 at 15:16 -0800, Ceraolo Spurio, Daniele wrote:
> On MTL the GSC FW needs to be loaded on the media GT by the graphics
> 
> 
> @@ -246,6 +253,10 @@ __uc_fw_auto_select(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw)
>  	int i;
>  	bool found;
>  
> +	/* FW is not defined until all the support is in place */
Nit: perhaps a little bit more explanation would be better here for folks reading thru the codes
> +	if (uc_fw->type == INTEL_UC_FW_TYPE_GSC)
> +		return;
> +