[Intel-gfx] [PATCH v2 2/3] drm/i915: Name our BARs based on the spec
Matthew Auld
matthew.william.auld at gmail.com
Thu Oct 6 08:42:17 UTC 2022
On Wed, 5 Oct 2022 at 20:56, Ville Syrjala
<ville.syrjala at linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> We use all kinds of weird names for our base address registers.
> Take the names from the spec and stick to them to avoid confusing
> everyone.
>
> The only exceptions are IOBAR and LMEMBAR since naming them
> IOBAR_BAR and LMEMBAR_BAR looks too funny, and yet I think
> that adding the _BAR to GTTMMADR & co. (which don't have one
> in the spec name) does make it more clear what they are.
> And IOBAR vs. GTTMMADR_BAR also looks a bit too inconsistent
> for my taste.
>
> v2: Fix gvt build
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Acked-by: Matthew Auld <matthew.auld at intel.com>
More information about the Intel-gfx
mailing list