[Intel-gfx] [PATCH v3 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types

Alan Previn alan.previn.teres.alexis at intel.com
Wed Oct 19 07:29:28 UTC 2022


After initial upstream merge of GuC error-capture feature, we eventually
decided to remove a lot of unnecessary warning messages when we couldn't
retrieve register lists for ADS-error-state-capture initialization. It was
a justified decision because the majority of that noise was being repeated
three times per GT reset and included list-types that are not supported
upstream. However after that change, we are not able to catch cases of
missing register lists for new engines that hadn't been added.

This series introduces new selective checks and warnings (such as skipping
if its a VF or if its an empty register list). This series also adds register
list for compute engine which is merely a duplicate of render class list.

Changes from prior revs:

   v2 : - Fix build error.
   v1 : - Fix the drm_warn string split (Tvrtko Ursulin / John Harrison)
        - Minor cosmetics around the drm_warn message checks (Tvrtko Ursulin /
          John Harrison)
        - Dont use empy string in stringify functions (Tvrtko Ursulin)
        - Ensure guc_capture_output_min_size_est doesn't trigger
          the drm_warn when calculating estimation size for worst case
          engine counts that may not exist (Alan Previn).

Alan Previn (2):
  drm/i915/guc: Add error-capture init warnings when needed
  drm/i915/guc: Add compute reglist for guc err capture

 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 82 +++++++++++++++++--
 1 file changed, 73 insertions(+), 9 deletions(-)


base-commit: b249abef9f86f788e6bacc657ae8eb7743948200
-- 
2.34.1



More information about the Intel-gfx mailing list