[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Selftest fixes for 6.1

Patchwork patchwork at emeril.freedesktop.org
Wed Oct 19 14:28:19 UTC 2022


== Series Details ==

Series: Selftest fixes for 6.1
URL   : https://patchwork.freedesktop.org/series/109879/
State : warning

== Summary ==

Error: dim checkpatch failed
b6a846cd517f drm/i915/selftests: Fix waiting for threads to start
-:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'array' - possible side-effects?
#141: FILE: drivers/gpu/drm/i915/i915_selftest.h:140:
+#define __igt_start_threads(array, num, cond, flag) \
+({ \
+	unsigned int n; \
+\
+restart: \
+	cond_resched(); \
+	for (n = 0; n < (num); n++) { \
+		if (array[n].cond && !READ_ONCE(array[n].running)) \
+			goto restart; \
+	} \
+})

-:141: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cond' may be better as '(cond)' to avoid precedence issues
#141: FILE: drivers/gpu/drm/i915/i915_selftest.h:140:
+#define __igt_start_threads(array, num, cond, flag) \
+({ \
+	unsigned int n; \
+\
+restart: \
+	cond_resched(); \
+	for (n = 0; n < (num); n++) { \
+		if (array[n].cond && !READ_ONCE(array[n].running)) \
+			goto restart; \
+	} \
+})

-:141: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#141: FILE: drivers/gpu/drm/i915/i915_selftest.h:140:
+#define __igt_start_threads(array, num, cond, flag) \
+({ \
+	unsigned int n; \
+\
+restart: \
+	cond_resched(); \
+	for (n = 0; n < (num); n++) { \
+		if (array[n].cond && !READ_ONCE(array[n].running)) \
+			goto restart; \
+	} \
+})

total: 0 errors, 1 warnings, 2 checks, 439 lines checked
101cf31aff47 drm/i915/selftests: Fix selftests for 6.1 kthread_stop semantics
-:7: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a7c01fa93aeb ("signal: break out of wait loops on kthread_stop()")'
#7: 
Since a7c01fa93aeb ("signal: break out of wait loops on kthread_stop()")

-:122: CHECK:LINE_SPACING: Please don't use multiple blank lines
#122: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:400:
 
+

total: 1 errors, 0 warnings, 1 checks, 97 lines checked




More information about the Intel-gfx mailing list