[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable YCbCr420 for VDSC

Patchwork patchwork at emeril.freedesktop.org
Fri Oct 28 13:43:01 UTC 2022


== Series Details ==

Series: Enable YCbCr420 for VDSC
URL   : https://patchwork.freedesktop.org/series/110253/
State : warning

== Summary ==

Error: dim checkpatch failed
725469674e5e drm/dp_helper: Add helper to check if the sink supports given format with DSC
-:20: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#20: FILE: include/drm/display/drm_dp_helper.h:196:
 }
+/* Check if sink supports DSC with given output format */

total: 0 errors, 0 warnings, 1 checks, 12 lines checked
f2af65f313e1 drm/i915/dp: Check if DSC supports the given output_format
359916e75b3c drm/i915: Adding the new registers for DSC
ee9a17fe123d drm/i915: Enable YCbCr420 for VDSC
-:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_row' - possible side-effects?
#189: FILE: drivers/gpu/drm/i915/display/intel_qp_tables.c:447:
+#define PARAM_TABLE(_minmax, _bpc, _row, _col, _is_420)  do { \
+	if (bpc == (_bpc)) {	\
+		if (_is_420)	\
+			return rc_range_##_minmax##qp420_##_bpc##bpc[_row][_col]; \
+		else	\
+			return rc_range_##_minmax##qp444_##_bpc##bpc[_row][_col]; \
+	}	\
 } while (0)

-:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_col' - possible side-effects?
#189: FILE: drivers/gpu/drm/i915/display/intel_qp_tables.c:447:
+#define PARAM_TABLE(_minmax, _bpc, _row, _col, _is_420)  do { \
+	if (bpc == (_bpc)) {	\
+		if (_is_420)	\
+			return rc_range_##_minmax##qp420_##_bpc##bpc[_row][_col]; \
+		else	\
+			return rc_range_##_minmax##qp444_##_bpc##bpc[_row][_col]; \
+	}	\
 } while (0)

total: 0 errors, 0 warnings, 2 checks, 228 lines checked
03df68b9395c drm/i915: Fill in native_420 field
411bbe96f7f6 drm/i915/dsc: Add debugfs entry to validate DSC YCbCr420
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
both RGB and YCbCr420 output formats by the sink, our policy is to try RGB first

-:26: WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#26: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1774:
+			   str_yes_no(drm_dp_dsc_sink_supports_format(intel_dp->dsc_dpcd, DP_DSC_YCbCr420_Native)));

total: 0 errors, 2 warnings, 0 checks, 109 lines checked
84bb46c116fe drm/i915/dsc: Allow DSC only with YCbCr420 format when forced from debugfs
-:20: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#20: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1510:
+	if (intel_dp->force_dsc_ycbcr420_en && pipe_config->output_format != INTEL_OUTPUT_FORMAT_YCBCR420)

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
6b5d2bc2cd05 drm/i915: Code styling fixes




More information about the Intel-gfx mailing list