[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Add "standalone media" support for MTL (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 2 23:50:50 UTC 2022


== Series Details ==

Series: i915: Add "standalone media" support for MTL (rev3)
URL   : https://patchwork.freedesktop.org/series/107908/
State : warning

== Summary ==

Error: dim checkpatch failed
37274f1f4068 drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume}
a54ec2ba43d9 drm/i915: Only hook up uncore->debug for primary uncore
884dc9b22c7f drm/i915: Use managed allocations for extra uncore objects
bc55b5f78d81 drm/i915: Prepare more multi-GT initialization
-:77: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "gtdef->setup"
#77: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:845:
+	     gtdef->setup != NULL;

total: 0 errors, 0 warnings, 1 checks, 145 lines checked
42e3ef15239e drm/i915: Rename and expose common GT early init routine
c89bcd0f475f drm/i915: Use a DRM-managed action to release the PCI bridge device
92209b602b0a drm/i915: Initialize MMIO access for each GT
305fc9377923 drm/i915: Handle each GT on init/release and suspend/resume
48cc0a18886f drm/i915/uncore: Add GSI offset to uncore
c7a1db1bf375 drm/i915/xelpmp: Expose media as another GT
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 11, in <module>
    import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 11, in <module>
    import git
ModuleNotFoundError: No module named 'git'
-:48: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

-:84: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!uncore->regs"
#84: FILE: drivers/gpu/drm/i915/gt/intel_sa_media.c:32:
+	if (drm_WARN_ON(&i915->drm, uncore->regs == NULL))

total: 0 errors, 1 warnings, 1 checks, 123 lines checked
ac9f18358457 drm/i915/mtl: Use primary GT's irq lock for media GT
-:85: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#85: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:800:
+		spinlock_t *irq_lock;

-:231: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#231: FILE: drivers/gpu/drm/i915/gt/intel_gt_types.h:160:
+	spinlock_t *irq_lock;

total: 0 errors, 0 warnings, 2 checks, 466 lines checked
dd8286e593bd drm/i915/mtl: Hook up interrupts for standalone media




More information about the Intel-gfx mailing list