[Intel-gfx] [PATCH] drm/i915: Let's avoid even early init if SLPC is used.

Dixit, Ashutosh ashutosh.dixit at intel.com
Tue Sep 6 23:20:47 UTC 2022


On Tue, 06 Sep 2022 13:33:49 -0700, Rodrigo Vivi wrote:
>

Hi Rodrigo,

>  void intel_rps_init_early(struct intel_rps *rps)
>  {
> +	if (rps_wants_slpc(rps))
> +		return;
> +

So what happens if we "want" SLPC but finally could not enable it (switch
slpc to "in use") and have to fall back to host turbo? If that's a valid
possibility then we can't do the above.

From drivers/gpu/drm/i915/gt/uc/intel_uc.h

 * - Not supported: not available in HW and/or firmware not defined.
 * - Supported: available in HW and firmware defined.
 * - Wanted: supported + enabled in modparam.
 * - In use: wanted + firmware found on the system and successfully fetched.

Thanks.
--
Ashutosh


More information about the Intel-gfx mailing list