[Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915

[Murthy, Arun R]

> On Fri, 09 Sep 2022, "Murthy, Arun R" <arun.r.murthy at intel.com> wrote:
> >> From: Suraj Kandpal <suraj.kandpal at intel.com>
> >>
> >> Adding WD Types, WD transcoder to enum list and WD Transcoder
> offsets.
> >> Adding i915 register definitions related to WD transcoder
> >>
> >> Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/display/intel_display.h  |   6 +
> >>  .../drm/i915/display/intel_display_types.h    |   1 +
> >>  drivers/gpu/drm/i915/i915_reg.h               | 139 ++++++++++++++++++
> >>  3 files changed, 146 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.h
> >> b/drivers/gpu/drm/i915/display/intel_display.h
> >> index fa5371036239..4e9f22954a41 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> >> @@ -120,6 +120,8 @@ enum transcoder {
> >>  	TRANSCODER_DSI_1,
> >>  	TRANSCODER_DSI_A = TRANSCODER_DSI_0,	/* legacy DSI */
> >>  	TRANSCODER_DSI_C = TRANSCODER_DSI_1,	/* legacy DSI */
> >> +	TRANSCODER_WD_0,
> >> +	TRANSCODER_WD_1,
> >>
> >>  	I915_MAX_TRANSCODERS
> >>  };
> >> @@ -141,6 +143,10 @@ static inline const char *transcoder_name(enum
> >> transcoder transcoder)
> >>  		return "DSI A";
> >>  	case TRANSCODER_DSI_C:
> >>  		return "DSI C";
> >> +	case TRANSCODER_WD_0:
> >> +		return "WD 0";
> >> +	case TRANSCODER_WD_1:
> >> +		return "WD 1";
> >>  	default:
> >>  		return "<invalid>";
> >>  	}
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> index 0da9b208d56e..0e94bd430bcb 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> @@ -79,6 +79,7 @@ enum intel_output_type {
> >>  	INTEL_OUTPUT_DSI = 9,
> >>  	INTEL_OUTPUT_DDI = 10,
> >>  	INTEL_OUTPUT_DP_MST = 11,
> >> +	INTEL_OUTPUT_WD = 12,
> >>  };
> >>
> >>  enum hdmi_force_audio {
> >> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> >> b/drivers/gpu/drm/i915/i915_reg.h index bf5c39d9f953..e3fced4b9980
> >> 100644
> >> --- a/drivers/gpu/drm/i915/i915_reg.h
> >> +++ b/drivers/gpu/drm/i915/i915_reg.h
> >> @@ -2059,6 +2059,8 @@
> >>  #define TRANSCODER_EDP_OFFSET 0x6f000
> >>  #define TRANSCODER_DSI0_OFFSET	0x6b000
> >>  #define TRANSCODER_DSI1_OFFSET	0x6b800
> >> +#define TRANSCODER_WD0_OFFSET	0x6e000
> >> +#define TRANSCODER_WD1_OFFSET	0x6e800
> >>
> >>  #define HTOTAL(trans)		_MMIO_TRANS2(trans, _HTOTAL_A)
> >>  #define HBLANK(trans)		_MMIO_TRANS2(trans, _HBLANK_A)
> >> @@ -3831,6 +3833,11 @@
> >>  #define PIPE_DSI0_OFFSET	0x7b000
> >>  #define PIPE_DSI1_OFFSET	0x7b800
> >>
> >> +/* WD 0 and 1 */
> > Can this be changed to
> > /* WD offset */
> 
> Nah, the comments should be removed altogether, they add zero value.
> That's literally what the macro name says already.
> 
That should be best!
Please remove this.

Thanks and Regards,
Arun R Murthy
-------------------
l Open Source Graphics Center