[Intel-gfx] [PATCH] drm/i915/selftests: Remove flush_scheduled_work() from live_execlists

Das, Nirmoy nirmoy.das at linux.intel.com
Fri Sep 23 10:32:24 UTC 2022


Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>

On 6/30/2022 2:57 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> There are ongoing efforts to remove usages of flush_scheduled_work() from
> drivers in order to avoid several cases of potentential problems when
> flushing is done from certain contexts.
>
> Remove the call from the live_execlists selftest. Its purpose was to be
> thorough and sync with the execlists capture state handling, but that is
> not strictly required for the test to function and can be removed.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp>
> ---
>   drivers/gpu/drm/i915/gt/selftest_execlists.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> index 09f8cd2d0e2c..e62d089257ae 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> @@ -85,8 +85,6 @@ static int wait_for_reset(struct intel_engine_cs *engine,
>   			break;
>   	} while (time_before(jiffies, timeout));
>   
> -	flush_scheduled_work();
> -
>   	if (rq->fence.error != -EIO) {
>   		pr_err("%s: hanging request %llx:%lld not reset\n",
>   		       engine->name,


More information about the Intel-gfx mailing list