[Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper

Lucas De Marchi lucas.demarchi at intel.com
Sat Sep 24 06:30:51 UTC 2022


On Fri, Sep 23, 2022 at 11:20:57AM +0300, Jani Nikula wrote:
>On Thu, 22 Sep 2022, Gustavo Sousa <gustavo.sousa at intel.com> wrote:
>> Use *_hpd_invert() helpers whenever possible to isolate logic specific
>> to hotplug inversion from common HPD setup logic to improve readability
>> and maintainability of the source code.
>>
>> While we only define dg1_hpd_invert() here, future platforms are likely
>> to have different hotplug inversion needs, thus it makes sense grouping
>> different implementations under a common suffix.
>>
>> v2: Fix coding style and prefer to use small *_hdp_invert() helpers
>>     instead of a generic one.
>>
>> CC: Jani Nikula <jani.nikula at linux.intel.com>
>> CC: Lucas De Marchi <lucas.demarchi at intel.com>
>> Signed-off-by: Gustavo Sousa <gustavo.sousa at intel.com>
>
>Reviewed-by: Jani Nikula <jani.nikula at intel.com>

applied, thanks

Lucas De Marchi


More information about the Intel-gfx mailing list