[Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects
Andrzej Hajda
andrzej.hajda at intel.com
Tue Sep 27 07:43:57 UTC 2022
On 23.09.2022 09:35, Nirmoy Das wrote:
> i915_gem_drain_workqueue() call i915_gem_drain_freed_objects()
> so no need to call that again.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/i915_gem.c | 2 --
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 7541028caebd..55d605c0c55d 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1236,8 +1236,6 @@ void i915_gem_driver_remove(struct drm_i915_private *dev_priv)
>
> /* Flush any outstanding unpin_work. */
> i915_gem_drain_workqueue(dev_priv);
> -
> - i915_gem_drain_freed_objects(dev_priv);
> }
>
> void i915_gem_driver_release(struct drm_i915_private *dev_priv)
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index fff11c90f1fa..f6a7c0bd2955 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -67,7 +67,6 @@ static void mock_device_release(struct drm_device *dev)
> intel_gt_driver_remove(to_gt(i915));
>
> i915_gem_drain_workqueue(i915);
> - i915_gem_drain_freed_objects(i915);
>
> mock_fini_ggtt(to_gt(i915)->ggtt);
> destroy_workqueue(i915->wq);
More information about the Intel-gfx
mailing list