[Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking

Niranjana Vishwanathapura niranjana.vishwanathapura at intel.com
Tue Sep 27 18:20:13 UTC 2022


On Tue, Sep 27, 2022 at 09:52:46AM +0300, Jani Nikula wrote:
>On Mon, 26 Sep 2022, Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com> wrote:
>> In await_fence_array(), unpacking syncobj pointer is not needed.
>> Remove it.
>
>Where are we with the goal of getting rid of all of ptr_pack_bits(),
>ptr_unpack_bits(), ptr_mask_bits() and ptr_unmask_bits()?
>

I am not sure, I just noticed this unwanted code while working on
VM_BIND patch series.

Regards,
Niranjana

>BR,
>Jani.
>
>
>>
>> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
>> ---
>>  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>> index cd75b0ca2555..8f5796cf9c9c 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>> @@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb,
>>  	int err;
>>
>>  	for (n = 0; n < eb->num_fences; n++) {
>> -		struct drm_syncobj *syncobj;
>> -		unsigned int flags;
>> -
>> -		syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2);
>> -
>>  		if (!eb->fences[n].dma_fence)
>>  			continue;
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list