[Intel-gfx] [PATCH 1/2] drm/i915/tc: demote a kernel-doc comment to a regular comment

Govindapillai, Vinod vinod.govindapillai at intel.com
Wed Apr 5 11:30:42 UTC 2023


On Wed, 2023-04-05 at 13:41 +0300, Jani Nikula wrote:
> There's not much point in a static work function having a kernel-doc
> comment. Just clean it up and make it a regular comment.
> 
> This fixes the kernel-doc warnings:
> 
> drivers/gpu/drm/i915/display/intel_tc.c:1370: warning: Function
> parameter or member 'work' not described in
> 'intel_tc_port_disconnect_phy_work'
> 
> drivers/gpu/drm/i915/display/intel_tc.c:1370: warning: Excess function
> parameter 'dig_port' description in 'intel_tc_port_disconnect_phy_work'
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---

Thanks.

Reviewed-by: Vinod Govindapillai <vinod.govindapillai at intel.com>


>  drivers/gpu/drm/i915/display/intel_tc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index 2bb02d4e6859..3b60995e9dfb 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -1358,10 +1358,7 @@ void intel_tc_port_lock(struct intel_digital_port *dig_port)
>         __intel_tc_port_lock(to_tc_port(dig_port), 1);
>  }
>  
> -/**
> - * intel_tc_port_disconnect_phy_work: disconnect TypeC PHY from display port
> - * @dig_port: digital port
> - *
> +/*
>   * Disconnect the given digital port from its TypeC PHY (handing back the
>   * control of the PHY to the TypeC subsystem). This will happen in a delayed
>   * manner after each aux transactions and modeset disables.



More information about the Intel-gfx mailing list