[Intel-gfx] [PATCH 11/12] drm/i915: Hook up csc into state checker

[Nautiyal, Ankit K]

LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>

On 3/29/2023 7:20 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Have the state checker validate that the csc matrices
> look correct when read back from the hardware.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display.c | 21 ++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index aa22241c971c..763f7fdfb27c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5643,6 +5643,24 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>   	} \
>   } while (0)
>   
> +#define PIPE_CONF_CHECK_CSC(name) do { \
> +	PIPE_CONF_CHECK_X(name.preoff[0]); \
> +	PIPE_CONF_CHECK_X(name.preoff[1]); \
> +	PIPE_CONF_CHECK_X(name.preoff[2]); \
> +	PIPE_CONF_CHECK_X(name.coeff[0]); \
> +	PIPE_CONF_CHECK_X(name.coeff[1]); \
> +	PIPE_CONF_CHECK_X(name.coeff[2]); \
> +	PIPE_CONF_CHECK_X(name.coeff[3]); \
> +	PIPE_CONF_CHECK_X(name.coeff[4]); \
> +	PIPE_CONF_CHECK_X(name.coeff[5]); \
> +	PIPE_CONF_CHECK_X(name.coeff[6]); \
> +	PIPE_CONF_CHECK_X(name.coeff[7]); \
> +	PIPE_CONF_CHECK_X(name.coeff[8]); \
> +	PIPE_CONF_CHECK_X(name.postoff[0]); \
> +	PIPE_CONF_CHECK_X(name.postoff[1]); \
> +	PIPE_CONF_CHECK_X(name.postoff[2]); \
> +} while (0)
> +
>   #define PIPE_CONF_QUIRK(quirk) \
>   	((current_config->quirks | pipe_config->quirks) & (quirk))
>   
> @@ -5740,6 +5758,9 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>   		PIPE_CONF_CHECK_COLOR_LUT(pre_csc_lut, true);
>   		PIPE_CONF_CHECK_COLOR_LUT(post_csc_lut, false);
>   
> +		PIPE_CONF_CHECK_CSC(csc);
> +		PIPE_CONF_CHECK_CSC(output_csc);
> +
>   		if (current_config->active_planes) {
>   			PIPE_CONF_CHECK_BOOL(has_psr);
>   			PIPE_CONF_CHECK_BOOL(has_psr2);