[Intel-gfx] [PATCH] drm/i915/mtl: Add support for PM DEMAND

[Gustavo Sousa]

Quoting Jani Nikula (2023-04-12 06:33:54)
> On Tue, 11 Apr 2023, Gustavo Sousa <gustavo.sousa at intel.com> wrote:
> > Quoting Mika Kahola (2023-04-03 05:50:43)
> >> @@ -8250,6 +8259,7 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv)
> >>         intel_color_init_hooks(dev_priv);
> >>         intel_init_cdclk_hooks(dev_priv);
> >>         intel_audio_hooks_init(dev_priv);
> >> +  intel_init_pmdemand(dev_priv);
> >
> > I think intel_init_display_hooks() is meant to call functions setting up
> > function pointers, right? That would not be the case for intel_init_pmdemand().
> >
> > I think we could rename intel_init_pmdemand() to
> > intel_pmdemand_init_early() and call it inside i915_driver_early_probe().
> 
> Please let's not add new direct calls to display from top level driver
> code. See also [1].

Okay. What would be the suggested place to do this SW-only initialization?

Should we just merge the two init functions into one named intel_pmdemand_init()
and call the new function under intel_modeset_init_noirq()?

--
Gustavo Sousa