[Intel-gfx] [PATCH 1/1] drm/i915/debugfs: New debugfs for display clock frequencies

Lucas De Marchi lucas.demarchi at intel.com
Fri Apr 14 15:51:32 UTC 2023


On Wed, Apr 12, 2023 at 12:22:51PM +0300, Jani Nikula wrote:
>On Wed, 12 Apr 2023, Bhanuprakash Modem <bhanuprakash.modem at intel.com> wrote:
>> +
>>  static ssize_t i915_displayport_test_active_write(struct file *file,
>>  						  const char __user *ubuf,
>>  						  size_t len, loff_t *offp)
>> @@ -1065,6 +1080,7 @@ static const struct drm_info_list intel_display_debugfs_list[] = {
>>  	{"i915_dp_mst_info", i915_dp_mst_info, 0},
>>  	{"i915_ddb_info", i915_ddb_info, 0},
>>  	{"i915_lpsp_status", i915_lpsp_status, 0},
>> +	{"i915_disply_clock_info", i915_display_clock_info, 0},
>
>Maybe "i915_cdclk_info"? (Also, disply has a typo there.)

hijacking this a little bit since I saw the new version of this commit
applied without the display_ part. Should we consider moving all the
display-related debugfs files to display/ directory?  I think that would
make it clearer for the xe integration while also cleaning up a little
bit the various files on i915. Downside would be synchronizing this with
the tools reading those files. I guess it's only igt and CI that care about
them?

Lucas De Marchi


More information about the Intel-gfx mailing list