[Intel-gfx] [PATCH] drm/i915/gt: Mask media GuC interrupts

Andi Shyti andi.shyti at linux.intel.com
Fri Apr 14 17:54:14 UTC 2023


Hi Daniele,

> > MTL features a dedicated media engine that operates on its
> > independent GT, requiring activation of its specific interrupt
> > set.
> > 
> > Enable the necessary interrupts in a single action when the media
> > engine is present, bypassing the need to iterate through all the
> > GTs.
> > 
> > Signed-off-by: Andi Shyti <andi.shyti at linux.intel.com>
> > ---
> > Hi,
> > 
> > I'm starting with v0 as this patch is very different from the
> > ones proposed recently.
> > 
> > After all the discussions on this patch, I took Matt's suggestion
> > since it seemed the most immediate.
> > 
> > However, in the long run, I agree that we should have a
> > specific mtl_ function for enabling interrupts.
> > 
> > Thank you Matt and Daniele for your input.
> > 
> > If this patch hasn't missed anything, is it too optimistic to
> > expect MTL to boot? :-)
> 
> The GSC engine also has interrupts tied to the media GT and those are
> conditional, so that engine won't work with just this patch. The system
> might boot because the GSC engine gets disabled if the FW is not there, but
> IMO if we want a single function to handle both GTs we need to do it proper
> support for the engines and not hack around just the GuC.

yeah... we are already having too many things to handle and at
this point I don't see any better way to handle this other than
using for_each_gt() as it was first sent.

Besides, they are different GT's, why not using for_each_gt?

Thank you, Daniele,
Andi


More information about the Intel-gfx mailing list