[Intel-gfx] [PATCH] drm/i915/pps: use intel_de_rmw() for panel unlock

[Andrzej Hajda]

On 17.04.2023 10:57, Jani Nikula wrote:
> Use rmw where needed.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_pps.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 7f9926672a6a..4f0b0cca03cc 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -1653,12 +1653,9 @@ void intel_pps_unlock_regs_wa(struct drm_i915_private *dev_priv)
>   	 */
>   	pps_num = intel_num_pps(dev_priv);
>   
> -	for (pps_idx = 0; pps_idx < pps_num; pps_idx++) {
> -		u32 val = intel_de_read(dev_priv, PP_CONTROL(pps_idx));
> -
> -		val = (val & ~PANEL_UNLOCK_MASK) | PANEL_UNLOCK_REGS;
> -		intel_de_write(dev_priv, PP_CONTROL(pps_idx), val);
> -	}
> +	for (pps_idx = 0; pps_idx < pps_num; pps_idx++)
> +		intel_de_rmw(dev_priv, PP_CONTROL(pps_idx),
> +			     PANEL_UNLOCK_MASK, PANEL_UNLOCK_REGS);
>   }
>   
>   void intel_pps_setup(struct drm_i915_private *i915)

Still some leftovers.

Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>

Regards
Andrzej