[Intel-gfx] [PATCH v4] drm/i915/display: Increase AUX timeout for Type-C

[Imre Deak]

On Tue, Apr 18, 2023 at 02:45:27PM +0300, Kandpal, Suraj wrote:
> [...]
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power_map.c
> > > b/drivers/gpu/drm/i915/display/intel_display_power_map.c
> > > index 6645eb1911d8..f0d51a30430a 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display_power_map.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_power_map.c
> > > @@ -1385,6 +1385,17 @@ static const struct i915_power_well_desc
> > xelpd_power_wells_main[] = {
> > >             ),
> > >             .ops = &icl_aux_power_well_ops,
> > >             .fixed_enable_delay = true,
> > > +   }, {
> > > +           .instances = &I915_PW_INSTANCES(
> > > +                   I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
> > > +                   I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
> > > +                   I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
> > > +                   I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
> > > +           ),
> >
> > Instead of duplicating the above 4 power wells the change should move them
> > to this group, as in the diff I provided.
> 
> You mean add the enable timeout in this instance itself

No, I meant moving the TC AUX power wells to a new group, as in the diff
I provided earlier. Attached is the updated patch.

> 
> {
>                 .instances = &I915_PW_INSTANCES(
>                         I915_PW("AUX_A", &icl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A),
>                         I915_PW("AUX_B", &icl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B),
>                         I915_PW("AUX_C", &icl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C),
>                         I915_PW("AUX_D", &icl_pwdoms_aux_d, .hsw.idx = XELPD_PW_CTL_IDX_AUX_D),
>                         I915_PW("AUX_E", &icl_pwdoms_aux_e, .hsw.idx = XELPD_PW_CTL_IDX_AUX_E),
>                         I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
>                         I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
>                         I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
>                         I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
>                 ),
>                 .ops = &icl_aux_power_well_ops,
>                 .fixed_enable_delay = true,
>         },
> 
> Regards,
> Suraj Kandpal
> > > +           .ops = &icl_aux_power_well_ops,
> > > +           .fixed_enable_delay = true,
> > > +           /* WA_14017248603: adlp */
> > > +           .enable_timeout = 500,
> > >     }, {
> > >             .instances = &I915_PW_INSTANCES(
> > >                     I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-i915-display-Increase-AUX-timeout-for-Type-C.patch
Type: text/x-diff
Size: 4118 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20230418/67e78139/attachment.patch>