[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mtl: add support for pmdemand (rev3)

Patchwork patchwork at emeril.freedesktop.org
Wed Apr 26 14:03:30 UTC 2023


== Series Details ==

Series: mtl: add support for pmdemand (rev3)
URL   : https://patchwork.freedesktop.org/series/116949/
State : warning

== Summary ==

Error: dim checkpatch failed
43c400d7f94f drm/i915: fix the derating percentage for MTL
1516c3767a49 drm/i915: update the QGV point frequency calculations
ab8840a89119 drm/i915: store the peak bw per QGV point
b38a10b76f6f drm/i915: extract intel_bw_check_qgv_points()
838ba80144b8 drm/i915: modify max_bw to return index to intel_bw_info
5297994969ad drm/i915/mtl: find best QGV point and configure sagv
01b1d8b5fa24 drm/i915/mtl: Add support for PM DEMAND
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:94: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#94: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:350:
+		struct mutex lock;

-:167: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#167: 
new file mode 100644

-:278: CHECK:LINE_SPACING: Please don't use multiple blank lines
#278: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:107:
+
+

-:487: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#487: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:316:
+#define GET_PARAM_VAL(f) ((u32)(old ? max(old->f, new->f) : new->f))

-:487: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#487: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:316:
+#define GET_PARAM_VAL(f) ((u32)(old ? max(old->f, new->f) : new->f))

-:726: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#726: FILE: drivers/gpu/drm/i915/i915_reg.h:4519:
+#define  XELPDP_PMDEMAND_QCLK_GV_BW(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_QCLK_GV_BW_MASK, x)

-:728: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#728: FILE: drivers/gpu/drm/i915/i915_reg.h:4521:
+#define  XELPDP_PMDEMAND_VOLTAGE_INDEX(x)		REG_FIELD_PREP(XELPDP_PMDEMAND_VOLTAGE_INDEX_MASK, x)

-:730: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#730: FILE: drivers/gpu/drm/i915/i915_reg.h:4523:
+#define  XELPDP_PMDEMAND_QCLK_GV_INDEX(x)		REG_FIELD_PREP(XELPDP_PMDEMAND_QCLK_GV_INDEX_MASK, x)

-:732: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#732: FILE: drivers/gpu/drm/i915/i915_reg.h:4525:
+#define  XELPDP_PMDEMAND_PIPES(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_PIPES_MASK, x)

-:734: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#734: FILE: drivers/gpu/drm/i915/i915_reg.h:4527:
+#define  XELPDP_PMDEMAND_DBUFS(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_DBUFS_MASK, x)

-:740: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#740: FILE: drivers/gpu/drm/i915/i915_reg.h:4533:
+#define  XELPDP_PMDEMAND_CDCLK_FREQ(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_CDCLK_FREQ_MASK, x)

-:742: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#742: FILE: drivers/gpu/drm/i915/i915_reg.h:4535:
+#define  XELPDP_PMDEMAND_DDICLK_FREQ(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_DDICLK_FREQ_MASK, x)

-:744: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#744: FILE: drivers/gpu/drm/i915/i915_reg.h:4537:
+#define  XELPDP_PMDEMAND_SCALERS(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_SCALERS_MASK, x)

total: 0 errors, 9 warnings, 4 checks, 675 lines checked
588c687d2318 drm/i915/display: provision to suppress drm_warn in intel_get_crtc_new_encoder




More information about the Intel-gfx mailing list