[Intel-gfx] [PATCH] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete
Teres Alexis, Alan Previn
alan.previn.teres.alexis at intel.com
Wed Aug 2 18:35:47 UTC 2023
> >
> >
alan:snip
Thanks Vinay and Daniele - i'll respin with below fix.
> > @@ -48,7 +50,8 @@ void intel_pxp_resume_complete()
> > if (!HAS_ENGINE(pxp->ctrl_gt, GSC0) && !pxp->pxp_component)
> > return;
> >
> > - intel_pxp_init_hw(pxp);
> > + with_intel_runtime_pm(&pxp->ctrl_gt->i915->runtime_pm, wakeref)
>
> This is called from within the rpm resume path, so you can't do an rpm
> get or it will deadlock. Maybe have:
>
> __pxp_resume_complete(struct intel_pxp *pxp, bool needs_rpm);
>
> intel_pxp_resume_complete(..)
> {
> return __pxp_resume_complete(pxp, true);
> }
>
> intel_pxp_runtime_resume(..)
> {
> return __pxp_resume_complete(pxp, false);
> }
>
>
> or something like that.
> Daniele
More information about the Intel-gfx
mailing list