[Intel-gfx] [PATCH] drm/i915: Fix mistake in intel_modeset_all_pipes condition

Stanislav Lisovskiy stanislav.lisovskiy at intel.com
Wed Aug 9 08:29:18 UTC 2023


It is supposed to be "!intel_crtc_needs_modeset" - otherwise,
we are active exactly vice versa for active pipes: skipping if modeset
is needed and not skipping if not needed.

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 763ab569d8f32..4b1d7034078ca 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -5439,7 +5439,7 @@ int intel_modeset_all_pipes(struct intel_atomic_state *state,
 			return PTR_ERR(crtc_state);
 
 		if (!crtc_state->hw.active ||
-		    intel_crtc_needs_modeset(crtc_state))
+		    !intel_crtc_needs_modeset(crtc_state))
 			continue;
 
 		drm_dbg_kms(&dev_priv->drm, "[CRTC:%d:%s] Full modeset due to %s\n",
-- 
2.37.3



More information about the Intel-gfx mailing list