[Intel-gfx] [PATCH v8 0/8] Add DSC PPS readout
Suraj Kandpal
suraj.kandpal at intel.com
Thu Aug 17 08:35:16 UTC 2023
Up until now we only verified one or two of the dsc pps
params like bits_per_component and bits_per_pixel this
patch series aim to readout almost all PPS param and get
them compared.
Along with that some work on making a common function to
read and write PPS param regiters is also done.
--v2
-Remove duplicated code and create function that fetches register
and reuse that. [Jani]
-move WARN_ON one abstraction layer up. [Jani]
-Split patch so that refactor and a new functionality is not added
in the same patch. [Jani]
-Add a new refactor patch so that bit shifting can be done in a
clean way. [Jani]
--v3
-Fix the typo in patch 2 [Jani]
-Get both dsc_reg regardless of dsc_eng_no. [Jani]
-Remove usage of num_vdsc_instances. [Ankit]
-Add macro to further optimize intel_dsc_get_pps_reg
--v4
-Manipulate register addresses rather than creating a macro to
manipulate variable name based on pps [Ankit]
--v5
-Use an array to fill the dsc registers instead of individual register
[Ankit]
-Get only dsc register that are required.
--v6
-make intel_get_no_vdsc_inst_per_pipe func static
--v7
-shorten func name for getting vdsc instances per pipe [Ankit]
-send no vdsc instances to dsc read and write reg funcs [Ankit]
--v8
-remove array dynamic allocation for dsc_reg [Jani]
-no need for an array to just verify dsc engine values [Jani]
-remove no_ from no_vdsc_per_pipe and wherever else it is
applicable [Ankit]
Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
Acked-by: Jani Nikula <jani.nikula at intel.com>
Suraj Kandpal (8):
drm/i915/vdsc: Refactor dsc register field macro
drm/i915/vdsc: Add a check for dsc split cases
drm/i915/vdsc: Add func to get no. of vdsc instances per pipe
drm/i915/vdsc: Add function to read any PPS register
drm/i915/vdsc: Add function to write in PPS register
drm/i915/vdsc: Remove unused dsc registers
drm/i915/vdsc: Fill the intel_dsc_get_pps_config function
drm/i915/display: Compare the readout dsc pps params
drivers/gpu/drm/i915/display/intel_display.c | 31 ++
drivers/gpu/drm/i915/display/intel_vdsc.c | 479 ++++++++----------
.../gpu/drm/i915/display/intel_vdsc_regs.h | 366 ++++---------
3 files changed, 347 insertions(+), 529 deletions(-)
--
2.25.1
More information about the Intel-gfx
mailing list