[Intel-gfx] [PATCH v3 1/4] drm/i915/tc: rename mtl_tc_port_get_pin_assignment_mask()

[Lucas De Marchi]

On Wed, Aug 16, 2023 at 09:08:44AM +0000, Coelho, Luciano wrote:
>On Wed, 2023-08-16 at 08:13 +0000, Kandpal, Suraj wrote:
>> > This function doesn't really return the pin assignment mask, but
>> > the max lane
>> > count derived from that.  So rename the function to
>> > mtl_tc_port_get_max_lane_count() to better reflect what it really
>> > does.
>> >
>> Maybe also add the version changes on commit messages here as cover
>> letter ends up getting discarded
>
>Ah, right.  I discussed this with someone else before and we agreed to
>disagree. 🙂 I don't really see the point in having the change history
>in the commit itself for the mainline.  The discussions should be
>openly available in the mailing list archives, so duplicating it in the
>commit logs, IMHO, is moot.
>
>A link in the commit log to lore, for instance, would add much more
>value IMHO.
>
>But anyway, since this guideline was already in place when I came, I
>will (almost grudgingly) comply. 😉

some people want them, some people want them removed. A lot of people in
drm like it while people outside will shout loudly if you add that.
Don't let this hold off getting the patch into a mergeable state. 


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

It may need a rebase though.

Lucas De Marchi

>
>>
>> With that fixed
>>
>> Reviewed-by: Suraj Kandpal <suraj.kandpal at intel.com>
>
>Thanks!
>
>--
>Cheers,
>Luca.