[Intel-gfx] [PATCH v2 19/22] drm/i915/dp_mst: Add missing DSC compression disabling

Lisovskiy, Stanislav stanislav.lisovskiy at intel.com
Thu Aug 24 09:44:16 UTC 2023


On Thu, Aug 24, 2023 at 11:05:14AM +0300, Imre Deak wrote:
> Add the missing DSC compression disabling step for MST streams,
> similarly to how this is done for SST outputs.
> 
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index b6a717566e7c8..5eaf309f852f2 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -656,6 +656,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
>  
>  	intel_ddi_disable_transcoder_func(old_crtc_state);
>  
> +	intel_dsc_disable(old_crtc_state);
> +

One thing that a bit I'm a bit concerned is that whether won't it conflict
with that intel_ddi_post_disable hook called for the last mst stream?

I see that it also calls intel_dsc_disable, however there is !mst check first,
however for Bigjoiner case, there is no such check.
Wondering should we add it there?..

>  	if (DISPLAY_VER(dev_priv) >= 9)
>  		skl_scaler_disable(old_crtc_state);
>  	else
> -- 
> 2.37.2
> 


More information about the Intel-gfx mailing list