[Intel-gfx] [PATCH 2/8] drm/i915/cdclk: Give the squash waveform length a name
Gustavo Sousa
gustavo.sousa at intel.com
Fri Dec 1 19:56:32 UTC 2023
Quoting Ville Syrjala (2023-11-28 08:51:32-03:00)
>From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
>Replace the slightly magic 'size = 16' with a bit more descriptive
>name. We'll have another user for this value later on.
>
>Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>
>---
> drivers/gpu/drm/i915/display/intel_cdclk.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
>index 0dca29ec799b..87d5e5b67c4e 100644
>--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
>+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
>@@ -1800,6 +1800,8 @@ static bool cdclk_pll_is_unknown(unsigned int vco)
> return vco == ~0;
> }
>
>+static const int cdclk_squash_len = 16;
>+
> static int cdclk_squash_divider(u16 waveform)
> {
> return hweight16(waveform ?: 0xffff);
>@@ -1811,7 +1813,6 @@ static bool cdclk_compute_crawl_and_squash_midpoint(struct drm_i915_private *i91
> struct intel_cdclk_config *mid_cdclk_config)
> {
> u16 old_waveform, new_waveform, mid_waveform;
>- int size = 16;
> int div = 2;
>
> /* Return if PLL is in an unknown state, force a complete disable and re-enable. */
>@@ -1850,7 +1851,8 @@ static bool cdclk_compute_crawl_and_squash_midpoint(struct drm_i915_private *i91
> }
>
> mid_cdclk_config->cdclk = DIV_ROUND_CLOSEST(cdclk_squash_divider(mid_waveform) *
>- mid_cdclk_config->vco, size * div);
>+ mid_cdclk_config->vco,
>+ cdclk_squash_len * div);
>
> /* make sure the mid clock came out sane */
>
>--
>2.41.0
>
More information about the Intel-gfx
mailing list