[Intel-gfx] [PATCH] drm/i915/edp: don't write to DP_LINK_BW_SET when using rate select

Ville Syrjälä ville.syrjala at linux.intel.com
Tue Dec 5 15:01:55 UTC 2023


On Tue, Dec 05, 2023 at 02:50:57PM +0200, Jani Nikula wrote:
> On Tue, 05 Dec 2023, "Shankar, Uma" <uma.shankar at intel.com> wrote:
> >> Yeah, writing 0 is done with an intention to disable it but that’s not the way to
> >> have this option disabled. Infact there is no reason to write to it for DP1.4+ if sink
> >> is compliant.
> >
> > The change looks ok and aligns with spec, its
> > Reviewed-by: Uma Shankar <uma.shankar at intel.com>
> 
> Ville, any further objections or concerns? Okay to merge?

I guess a small comment on why we're avoiding the BW_SET in there might
be good idea, lest we forget and try to reunify the two branches by 
accident. But otherwise seems fine.

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list