[PATCH] drm/xe: Fix build without CONFIG_FAULT_INJECTION

Dixit, Ashutosh ashutosh.dixit at intel.com
Mon Dec 18 18:51:03 UTC 2023


On Mon, 18 Dec 2023 06:57:14 -0800, Thomas Hellström wrote:
>
>
> On 12/18/23 15:30, Rodrigo Vivi wrote:
> > Ideally this header could be included without the CONFIG_FAULT_INJECTION
> > and it would take care itself for the includes it needs.
> > So, let's temporary workaround this by moving this below and including
> > only when CONFIG_FAULT_INJECTION is selected to avoid build breakages.
> >
> > Another solution would be us including the linux/types.h as well, but
> > this creates unnecessary cases.
> >
> > Reference: https://lore.kernel.org/all/20230816134748.979231-1-himal.prasad.ghimiray@intel.com/
> > Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> > Cc: Oded Gabbay <ogabbay at kernel.org>
> > Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> LGTM.
>
> Reviewed-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>

Hmm, msm/msm_drv.c doesn't seem to need to do this. Anyway maybe ok for a
temporary fix...


More information about the Intel-gfx mailing list