[Intel-gfx] [PATCH 07/13] drm/i915/dsb: Nuke the DSB debug

Manna, Animesh animesh.manna at intel.com
Thu Feb 2 17:19:43 UTC 2023



> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Ville
> Syrjala
> Sent: Wednesday, January 18, 2023 10:01 PM
> To: intel-gfx at lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 07/13] drm/i915/dsb: Nuke the DSB debug
> 
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We'll be wanting to start the DSB from the vblank evasion critical section so
> printk()s are a big nono. Get rid if the debug print.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

LGTM.
Reviewed-by: Animesh Manna <animesh.manna at intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dsb.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c
> b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 43679090eceb..96159d69bbff 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -265,11 +265,6 @@ void intel_dsb_commit(struct intel_dsb *dsb, bool
> wait_for_vblank)
>  		       i915_ggtt_offset(dsb->vma));
>  	intel_de_write(dev_priv, DSB_TAIL(pipe, dsb->id),
>  		       i915_ggtt_offset(dsb->vma) + tail);
> -
> -	drm_dbg_kms(&dev_priv->drm,
> -		    "DSB execution started - head 0x%x, tail 0x%x\n",
> -		    i915_ggtt_offset(dsb->vma),
> -		    i915_ggtt_offset(dsb->vma) + tail);
>  }
> 
>  void intel_dsb_wait(struct intel_dsb *dsb)
> --
> 2.38.2



More information about the Intel-gfx mailing list